Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Oct 13, 2021

When we moved to github registry, the --github-image-id flag was
broken as it had pulled the "latest" image when run right after
pulling the tagged image (and it run that image instead).

This change fixes it and uses GITHUB_PULL_IMAGE_TAG (latest if not
specified) everywhere where the image is used for running.
This flag is not persistent so it is not persistent.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@potiuk
Copy link
Member Author

potiuk commented Oct 13, 2021

@potiuk potiuk force-pushed the fix-pulling-github-id branch from 926052b to f3b550b Compare October 13, 2021 14:05
@potiuk
Copy link
Member Author

potiuk commented Oct 13, 2021

Looks good this time @jedcunningham > there are failures in my fork but they are unrelated

When we moved to github registry, the --github-image-id flag was
broken as it had pulled the "latest" image when run right after
pulling the tagged image (and it run that image instead).

This change fixes it and uses GITHUB_PULL_IMAGE_TAG (latest if not
specified) everywhere where the image is used for running.
This flag is not persistent so it is not persistent.
@potiuk potiuk force-pushed the fix-pulling-github-id branch from f3b550b to d8f9239 Compare October 14, 2021 10:51
@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Oct 14, 2021
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk potiuk merged commit 0a82a42 into apache:main Oct 14, 2021
@potiuk potiuk deleted the fix-pulling-github-id branch October 14, 2021 14:25
potiuk added a commit that referenced this pull request Jan 22, 2022
When we moved to github registry, the --github-image-id flag was
broken as it had pulled the "latest" image when run right after
pulling the tagged image (and it run that image instead).

This change fixes it and uses GITHUB_PULL_IMAGE_TAG (latest if not
specified) everywhere where the image is used for running.
This flag is not persistent so it is not persistent.

(cherry picked from commit 0a82a42)
@potiuk potiuk added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jan 22, 2022
@potiuk potiuk added this to the Airflow 2.2.4 milestone Jan 22, 2022
@potiuk potiuk restored the fix-pulling-github-id branch April 26, 2022 20:46
@potiuk potiuk deleted the fix-pulling-github-id branch July 29, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants