-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Changing password as it gets masked across logs and causes issues #19139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing password as it gets masked across logs and causes issues #19139
Conversation
Do you remember which one? |
|
This one: tests.cli.commands.test_task_command.TestLogsfromTaskRunCommand |
|
Should we unquarantine the quarantined test as well ? |
|
@potiuk This PR tries to fix only 1 of 5 failing test cases within the suite and whole suite is marked as @pytest.mark.quarantined. That aside, although I am working on getting password changed everywhere it's used (which is quite a lot) I am not sure if it's ok from community perspective to do it and if they would prefer to keep as is i.e. "airflow"? In which case masking replaces airflow word with *** everywhere in the logs which will be problem I think all the time |
|
I see. Makes sense. I think it makes sense to change the password if it is in unit tests |
55e9955 to
d929db2
Compare
22e22ad to
d933cb8
Compare
4063dbc to
75cc13c
Compare
75cc13c to
b55477e
Compare
|
Closing in favor of this: #19858 |
Current postgres password gets masked during DB engine init and added to secret list and masked whenever mentioned in the logs.
As it currently set to "airflow" it's converted to *** everywhere airflow is printed in the logs including folder path etc.
Currently, this will fix one of the failing test cases from quarantined list that expects "airflow" path in the log but gets ***.
But this also should be noted for future similar cases as to not to name password as "airflow" or similar reserved/widely used words as they will be masked in the logs.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.