Skip masking airflow password for tests #19858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
reviewed
Nov 27, 2021
potiuk
approved these changes
Nov 27, 2021
Member
|
Should we also un-quarantine the quarantined tests ? |
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
Contributor
Author
|
At the moment quarantine is set on a class/suite level and there are some other issues in those test. I will fix one by one and once complete we can remove quarantine flag. |
Member
|
Sounds good. @ashb - are you ok with that? |
ashb
reviewed
Nov 29, 2021
Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com>
dillonjohnson
pushed a commit
to dillonjohnson/airflow
that referenced
this pull request
Dec 1, 2021
jedcunningham
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current "airflow" password gets masked whenever mentioned in the logs.
This causes word "airflow" to be replaced with *** in the logs including folder path etc.
This causes issue in some tests that read logs.
For example:
Test case: tests.cli.commands.test_task_command.TestLogsfromTaskRunCommand
It asserts for this value:
but gets
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.