Refactor query polling logic for athena queries #21488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
victorphoenix3
force-pushed
the
athena-polling
branch
2 times, most recently
from
f4a119d to
7766ddd
Compare
ferruzzi
approved these changes
Feb 10, 2022
Contributor
ferruzzi
left a comment
ferruzzi
left a comment
There was a problem hiding this comment.
You'll need to wait for a committer to approve and merge, but LGTM. 👍 Thanks for adding this one.
Member
|
Some tests are failing :( (related) |
Contributor
|
@victorphoenix3 can you please fix the failing tests? |
victorphoenix3
force-pushed
the
athena-polling
branch
from
7766ddd to
2e456d6
Compare
Contributor
Author
|
@eladkal I have updated the PR. Please review |
victorphoenix3
commented
Mar 7, 2022
Contributor
Author
There was a problem hiding this comment.
'SUCCESS' is not a state for athena queries, "SUCCEEDED" is. The tests were failing because of this discrepancy
Closed
Contributor
|
@victorphoenix3 can you please rebase? tests are broken due to issue with moto (was already fixed in #22046 ) |
victorphoenix3
force-pushed
the
athena-polling
branch
from
2e456d6 to
2a5c0a8
Compare
Contributor
Author
|
@eladkal PR is ready |
potiuk
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Query status polling logic currently polls until the query is not in intermmediate state. It should instead poll until query is not in the terminal state.
Similar to #19877