Skip to content

Conversation

@ledped
Copy link

@ledped ledped commented Feb 23, 2022

@potiuk pinned down the version due to limitations explained in this commit:
366c66b
The limitations have been lifted since issue pallets/markupsafe#284 was closed.

@potiuk pinned down the version due to limitations explained in this commit:
apache@366c66b
The limitations have been lifted since issue pallets/markupsafe#284 was closed.
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 23, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong. You can’t simply remove it because 2.1.0 is still incompatible. The most you can do is to change < to !=.

@ledped
Copy link
Author

ledped commented Feb 24, 2022

This is wrong. You can’t simply remove it because 2.1.0 is still incompatible. The most you can do is to change < to !=.

Updated as suggested, @uranusjr .

@ledped ledped requested a review from uranusjr February 24, 2022 13:45
@potiuk
Copy link
Member

potiuk commented Feb 25, 2022

@ledped - I think I managed to workaround the pip resolver issue with #21824 - please rebase to latest main.

@ledped ledped closed this Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants