Limits GitHub3.py in order to avoid backtracking #21824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github3 version 3.1.2 requires PyJWT>=2.3.0 which clashes with Flask App Builder where PyJWT is <2.0.0 Actually GitHub3.1.0 already introduced PyJWT>=2.3.0 but so far `pip` was able to resolve it without getting into a long backtracking loop and figure out that github3 3.0.0 version is the right version similarly limiting it to 3.1.2 causes pip not to enter the backtracking loop. Apparently when there Are 3 versions with PyJWT>=2.3.0 (3.1.0, 3.1.1 an 3.1.2) pip enters into backtrack loop and fails to resolve that github3 3.0.0 is the right version to use. This limitation could be removed if PyJWT limitation < 2.0.0 is dropped from FAB or when pip resolution is improved to handle the case, The issue which describes this PIP behaviour and hopefully allowing to improve it is tracked in pypa/pip#10924.
potiuk
requested review from
ashb,
dstandish,
eladkal,
ephraimbuddy and
kaxil
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
1 similar comment
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Member
Author
|
That was an accidental fail with image 3.9. Merging. |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Feb 25, 2022
This is a follow-up after investigation done with failing main builds (resulting in apache#21824 and tracked in pypa/pip#10924)
This was referenced Feb 25, 2022
Contributor
|
thank you @potiuk 🙏 |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Feb 27, 2022
This is a follow-up after investigation done with failing main builds (resulting in apache#21824 and tracked in pypa/pip#10924) Handling failure of image building has been also improved as part of the PR. Instead of separate "cancel" job (which did not really work anyway) we build and push empty images instead and the empty images are handled in the "wait for images" job with appropriate message.
jedcunningham
added
the
type:misc/internal
potiuk
added a commit
that referenced
this pull request
Mar 3, 2022
…21825) * Add CI jobs and tooling to aid with tracking backtracking pip issues This is a follow-up after investigation done with failing main builds (resulting in #21824 and tracked in pypa/pip#10924) Handling failure of image building has been also improved as part of the PR. Instead of separate "cancel" job (which did not really work anyway) we build and push empty images instead and the empty images are handled in the "wait for images" job with appropriate message. * Update dev/breeze/src/airflow_ci/find_newer_dependencies.py Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com> Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com>
ephraimbuddy
added
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github3 version 3.1.2 requires PyJWT>=2.3.0 which clashes with Flask App
Builder where PyJWT is <2.0.0 Actually GitHub3.1.0 already introduced
PyJWT>=2.3.0 but so far
pipwas able to resolve it without gettinginto a long backtracking loop and figure out that github3 3.0.0 version
is the right version similarly limiting it to 3.1.2 causes pip not to
enter the backtracking loop. Apparently when there Are 3 versions with
PyJWT>=2.3.0 (3.1.0, 3.1.1 an 3.1.2) pip enters into backtrack loop and
fails to resolve that github3 3.0.0 is the right version to use.
This limitation could be removed if PyJWT limitation < 2.0.0 is dropped
from FAB or when pip resolution is improved to handle the case, The
issue which describes this PIP behaviour and hopefully allowing to
improve it is tracked in pypa/pip#10924.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.