Add check for coerce_datetime to Airflow 2-1 compatibility check #22499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
|
Member
Author
|
CC: @lwyszomi -> this one will fail now so I will rebase after your PR is merged. |
Contributor
|
This probably means RC2 for google provider? |
Contributor
|
@potiuk thanks :) |
uranusjr
approved these changes
Mar 24, 2022
eladkal
approved these changes
Mar 24, 2022
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
Member
Author
Not really. This is just 2.1+ compatibility problem and it has been already released so it is not a "regression" in the new release. BTW. It was actually me who introduced it here: 3728494 🤦 |
Contributor
Member
Author
|
True. That was actually a teamwork :) |
potiuk
force-pushed
the
consolidate-provider-2-1-compatibility-checks
branch
4 times, most recently
from
766cf3d to
2a5d2df
Compare
Checking coerce_datetime presence (and also consolidating all 2.1 checks in a single pre-commit check).
potiuk
force-pushed
the
consolidate-provider-2-1-compatibility-checks
branch
from
2a5d2df to
10f108d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking coerce_datetime presence (and also consolidating all
2.1 checks in a single pre-commit check).
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.