Skip to content

Conversation

@lwyszomi
Copy link
Contributor

Related to the issue with the compatibility with Airflow 2.1.+


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@lwyszomi lwyszomi requested a review from turbaszek as a code owner March 24, 2022 11:08
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Mar 24, 2022
@lwyszomi
Copy link
Contributor Author

@potiuk PR should fix #22499

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not we actually check and convert "potential" dt.timetime to pendulum.DateTime here and below ? that's what corce_datetime did actually.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @uranusjr ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think we should. Since context["execution_date"] can never be None, this can simply use pendulum.instance. The following_schedule() one below needs an additional check because it can be None.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uranusjr I will convert to the pendulum object. but regarding following_schedule we checking if the result is None, what additional check you have in mind?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply something like

following_execution_date = context["dag"].following_schedule(context["execution_date"])
if following_execution_date is None:
    timespan_end: Optional[pendulum.DateTime] = None
else:
    timespan_end = pendulum.instance(following_execution_date)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, make sense

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Mar 24, 2022
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk potiuk merged commit d231e9b into apache:main Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers okay to merge It's ok to merge this PR as it does not require more tests provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants