Skip to content

Conversation

@ferruzzi
Copy link
Contributor

Cleans up the existing sample DAG and docs for the SageMaker operators.
Part of a project to standardize AWS sample dags and docs in preparation for adding System Testing.

Related: #21523
Related: #21475
Related: #21828
Related: #21920
etc...

@ferruzzi ferruzzi requested a review from mik-laj as a code owner April 26, 2022 14:31
@ferruzzi ferruzzi force-pushed the ferruzzi/docs-update/sagemaker branch from 8e61e36 to 470b4ee Compare April 26, 2022 14:33
@ferruzzi
Copy link
Contributor Author

Please note: The operators have do_xcom_push=False because they currently fail at the very end with the message "Object of type datetime is not JSON serializable". This is a temporary workaround and can be fixed by adding json.dumps() to the return statements. For example: change return self.hook.describe_endpoint_config(endpoint_info['EndpointConfigName']) to return json.dumps(self.hook.describe_endpoint_config(endpoint_info['EndpointConfigName']), cls=AirflowJsonEncoder).

I will submit a fix for those next, but that is outside the scope of this PR.

@ferruzzi ferruzzi force-pushed the ferruzzi/docs-update/sagemaker branch from 941cb35 to 169cc3f Compare April 28, 2022 23:14
@ferruzzi
Copy link
Contributor Author

ferruzzi commented May 2, 2022

@eladkal may want eyes on this one since he has reviewed most/all of the others in this collection of changes.

@ferruzzi ferruzzi force-pushed the ferruzzi/docs-update/sagemaker branch from 169cc3f to e1c2581 Compare May 2, 2022 19:39
@ferruzzi ferruzzi mentioned this pull request May 2, 2022
@potiuk potiuk merged commit ad863ce into apache:main May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants