[AIRFLOW-1380] Update import to work with latest Docker client #2417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes import of Docker client library to make it compatible with the latest version.
|
@benjaminsims, thanks for your PR! By analyzing the history of the files in this pull request, we identified @asnir, @vitorbaptista and @artwr to be potential reviewers. |
Allow user to specify temporary directory to use on the host machine; default settings will cause an error on OS X due to the standard temporary directory not being shared to Docker.
Allow the user to specify the working directory to be used in the created container. Equivalent to docker run/create -w.
Requirements
|
Somebody is working on this? It's really important for us to be able to launch containers with python library, this way we don't have to install docker client on the container. |
Contributor
|
@benjaminsims Could you close this PR? It has been fixed in #3407 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Airflow maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
The API for the Docker client was changed and 'Client' renamed to 'APIClient' (see docker/docker-py@9daa320).
This PR updates the import to reflect the name change.
Tests
Unit tests are broken when running using the latest version of the Docker client; I have modified the unit tests to import the new version instead.
Commits