Skip to content

[AIRFLOW-1057][AIRFLOW-1380][AIRFLOW-2362] Update DockerOperator to new Docker API #3407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Noremac201 wants to merge 1 commit into from
Closed

[AIRFLOW-1057][AIRFLOW-1380][AIRFLOW-2362] Update DockerOperator to new Docker API #3407

Noremac201 wants to merge 1 commit into from

Conversation

@Noremac201
Copy link
Contributor

@Noremac201 Noremac201 commented May 23, 2018

JIRA

Description

  • Here are some details about my PR, including screenshots of any UI changes:

update import to docker's new API version >=2.0.0
changed dependency for docker package; now docker rather than docker-py
updated test cases to align to new docker class

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • Passes git diff upstream/master -u -- "*.py" | flake8 --diff

@wasperen @Noremac201
[AIRFLOW-1057][AIRFLOW-1380][AIRFLOW[2362] Update DockerOperator to n…
101ea68 
…ew API

update import to docker's new API version >=2.0.0
changed dependency for docker package; now docker rather than docker-py
updated test cases to align to new docker class
@Noremac201 Noremac201 changed the title [AIRFLOW-1057][AIRFLOW-1380][AIRFLOW[2362] Update DockerOperator to new Docker API [AIRFLOW-1057][AIRFLOW-1380][AIRFLOW-2362] Update DockerOperator to new Docker API May 23, 2018
@codecov-io
Copy link

codecov-io commented May 23, 2018

Codecov Report

Merging #3407 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3407      +/-   ##
==========================================
- Coverage    76.5%   76.49%   -0.01%     
==========================================
  Files         203      203              
  Lines       15022    15022              
==========================================
- Hits        11492    11491       -1     
- Misses       3530     3531       +1
Impacted Files Coverage Δ
airflow/operators/docker_operator.py 97.67% <100%> (ø) ⬆️
airflow/hooks/docker_hook.py 91.89% <100%> (ø) ⬆️
airflow/models.py 86.99% <0%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cedcdb1...101ea68. Read the comment docs.

Fokko
Fokko approved these changes May 24, 2018
View reviewed changes
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging this one in favor of #2417 since the tests are all green.

@asfgit asfgit closed this in 4955691 May 24, 2018
@Fokko Fokko mentioned this pull request May 24, 2018
Closed
4 tasks
@Noremac201 Noremac201 deleted the fixer branch May 24, 2018 18:07
sekikn pushed a commit to sekikn/airflow that referenced this pull request May 28, 2018
@wasperen @sekikn
[AIRFLOW-1057][AIRFLOW-1380][AIRFLOW-2362][2362] AIRFLOW Update Docke…
842b6cb 
…rOperator to new API

update import to docker's new API version >=2.0.0
changed dependency for docker package; now docker
rather than docker-py
updated test cases to align to new docker class

Closes apache#3407 from Noremac201/fixer
@gerardo gerardo mentioned this pull request Jun 26, 2018
Closed
4 tasks
@ashb ashb mentioned this pull request Oct 23, 2018
Closed
4 tasks
aliceabe pushed a commit to aliceabe/incubator-airflow that referenced this pull request Jan 3, 2019
@wasperen
[AIRFLOW-1057][AIRFLOW-1380][AIRFLOW-2362][2362] AIRFLOW Update Docke…
211811c 
…rOperator to new API

update import to docker's new API version >=2.0.0
changed dependency for docker package; now docker
rather than docker-py
updated test cases to align to new docker class

Closes apache#3407 from Noremac201/fixer
ranlu pushed a commit to seung-lab/airflow that referenced this pull request Apr 21, 2019
@wasperen @ranlu
[AIRFLOW-1057][AIRFLOW-1380][AIRFLOW-2362][2362] AIRFLOW Update Docke…
f518b80 
…rOperator to new API

update import to docker's new API version >=2.0.0
changed dependency for docker package; now docker
rather than docker-py
updated test cases to align to new docker class

Closes apache#3407 from Noremac201/fixer

Conflicts:
	setup.py
	tests/operators/docker_operator.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fokko Fokko Fokko approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Noremac201 @codecov-io @Fokko @wasperen