Skip to content

Conversation

@dwreeves
Copy link
Contributor

@dwreeves dwreeves commented Jun 21, 2022

Closes: #24572.

@dwreeves dwreeves requested a review from mik-laj as a code owner June 21, 2022 02:29
@boring-cyborg boring-cyborg bot added area:providers kind:documentation provider:snowflake Issues related to Snowflake provider labels Jun 21, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 21, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@dwreeves dwreeves force-pushed the snowflake-connection-documentation branch from 086f0b7 to c4e6916 Compare June 21, 2022 02:38
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this paragraph to section below?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@dwreeves dwreeves requested a review from mik-laj June 24, 2022 03:05
@mik-laj
Copy link
Member

mik-laj commented Jun 26, 2022

LGTM, but CI is sad, so I rebased this branch.

@mik-laj mik-laj force-pushed the snowflake-connection-documentation branch from c255141 to 2447679 Compare June 26, 2022 15:13
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Jun 26, 2022
@github-actions
Copy link

The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@dwreeves
Copy link
Contributor Author

Excellent. Thank you for the review and for fixing the CI!

@mik-laj mik-laj merged commit 2fb93f8 into apache:main Jun 27, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 27, 2022

Awesome work, congrats on your first merged pull request!

@dwreeves dwreeves deleted the snowflake-connection-documentation branch July 16, 2022 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers kind:documentation okay to merge It's ok to merge this PR as it does not require more tests provider:snowflake Issues related to Snowflake provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Snowflake Provider connection documentation is misleading

2 participants