Snowflake Provider Package - hide host from UI #29208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:snowflake
Contributor
Author
|
Ah, woops, I meant to link to #24572. |
58 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses an unfinished problem relating to
#29207#24572In #24573, the Snowflake provider package's documentation was updated to reflect the fact that the
hostis never used in theSnowflakeHook().However, it still shows up in the UI. I didn't realize that this could be hidden until just now after helping someone with another problem related to hooking up the Snowflake connection. So we should remove it.
(You can CTRL+F the Snowflake hook source code to confirm the host really is never used as part of the connection.)