added labels to airflow specific pods #25031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…:rishkarajgi/airflow into feature/support-labels-per-component-mod
Contributor
|
@jedcunningham - pls see if this can be merged |
Member
jedcunningham
left a comment
jedcunningham
left a comment
There was a problem hiding this comment.
Component specific labels should go on all objects, not just pods, like the global labels do. Also there are merge conflicts currently.
…:rishkarajgi/airflow into feature/support-labels-per-component-mod
rishkarajgi
requested review from
jedcunningham
and removed request for
dstandish
Contributor
Author
@jedcunningham Have addressed the above. Please take a look |
…:rishkarajgi/airflow into feature/support-labels-per-component-mod
…:rishkarajgi/airflow into feature/support-labels-per-component-mod
jedcunningham
approved these changes
Aug 23, 2022
bote795
pushed a commit
to astronomer/airflow
that referenced
this pull request
Aug 23, 2022
This was referenced Aug 23, 2022
25 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to inject additional labels to specific components. This currently supports addition to scheduler, webserver, worker, pod template, triggerer, flower, cleanup and create user job.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.