added component specific labels #24668
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
Contributor
|
@mayankbatra123 Is this PR feature complete? |
Member
|
@mayankbatra123 - I think everything we work on here is community Airflow. If you want to discuss with astronomer on adding stuff for Astronomer, this is not the right forum (and this one is wrong). I am not even sure what you are talking about here. |
Member
|
This one has static chceks and docs failing. You need to fix it before we review it @mayankbatra123 |
We do not need to run upgrade kubernetes tests for all python versions and all kubernetes versions. It is enough to run them for the minimum and maximum versions. We already run all k8s tests in main for all executors, so they "generally" work, and it is very, very unlikely that if it works for Python 3.7, and 3.10, it will not work for 3.8 or 3.9 (similarly for K8S version). This will speed up the build at least 2 times.
…he#25155) * Update description of branch creation to include the new Breeze The new Breeze has a different place where default branch and constraints branch are kept. When we create a new "release" branch we should update it here as well as in the bash legacy breeze (until the bash breeze has stil some zombies around)
* generate api types from swagger docs, add map_index to task instance api schema
* Update useGridData.ts * Update useGridData.test.js * Update useGridData.test.js
This release is 3.0.1, not 3.1.0 --right?
…#25181) Having dag1, dag2 etc was not telling much about the different dataset dags
Previously, in order to keep consistent development environment we've compiled javascript in the CI image. However we can utilise power of pre-commmit for setting the node environment for all contributors automatically. Instead of compiling the javascript in the image, we can compile it via pre-commit in the host. This can be done thanks to the new python breeze which is far more flexible and can now add execution of compilation of the javascript when needed and using pre-commit environments. Thanks to that, we can vastly simplify the Dockerfiles and scripts that are used to automatically build or signal that the assets need recompilation. We can basically assume that the assets were prepared outside of the image building (and breeze makes sure it happens) The changes: * node.js is not needed in images (neither PROD build nor CI) * no need for multiple asset compilation scripts. All is done via pre-commit environment with `breeze compile-www-assets`` command * lint checks for UI do not need the docker image any more (they are also based on pre-commit environment) * no more checks/warnings when you enter the image * start-airflow command builds the compilation before entering * prepare-airflow-package runs asset compilation before entering docker airflow building.
Asset compilation via setup.py has been broken in apache#25169. This PR fixes it.
mysql lib does support newer version of python pymssql/pymssql#659
I missed the hive provider from the commit in apache#25214
Assets compilation when CI and PROD images are prepared should also be run in non-main branch.
…ation_for_ids` docs (apache#25197)
* dataset details view * Fix sorting and naming * update table tests * update comments
* Convert RDS Export Sample DAG to System Test * PR Fixes
There are two issues with mapped sensor with `reschedule` mode. First, the reschedule table is being populated with a default map_index of -1 even when the map_index is not -1. Secondly, MappedOperator does not have the `ReadyToReschedule` dependency. This PR is an attempt to fix this Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
We previously had this for just the `celery worker` subcommand, this PR extends it to anything that can run in daemon mode
…che#25649) While releasing the providers two small problems were detected (as I recreated all my envs from scratch and released even rc3 this time :))
The problem was caused by using `ProviderInfo.is_source` field that was introduced only in Airflow 2.3.0.
…les (apache#25670) Renamed files are listed by github to start with `{old-filename} -> {new-filename}`. Currently, these are treated as core files. Here we search the renamed files if it starts with what should be ignored
For whatever reason, this makes PyLance able to infer the wrapped function's signature, which is a nice improvement.
We changed the UI to use these new terms already, but the code wasn't changed. These names are clearer to me (and others) so I have made the code reflect them too.
mayankbatra123
requested review from
Fokko,
XD-DENG,
ashb,
bbovenzi,
ephraimbuddy,
jhtimmins,
kaxil,
mik-laj,
potiuk,
ryanahamilton,
turbaszek and
uranusjr
as code owners
Member
|
This one’s pretty broken |
Member
|
Closing this as #25031 has added this feature. Thanks @mayankbatra123! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named
{pr_number}.significant.rst, in newsfragments.