Clean up the AWS System Test ContextBuilder#25773
Merged
potiuk merged 2 commits intoapache:mainfrom Aug 27, 2022
Merged
Conversation
ferruzzi
force-pushed
the
ferruzzi/system-tests/refactor-context-builder
branch
from
0469618 to
7c65aee
Compare
potiuk
approved these changes
Aug 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SystemTestContextBuilder allows the system tests to generate ENV_ID and to fetch variable values from a number or sources. This PR cleans up how that information is stored and retrieved without changing the user-facing interface. Multiple (unsynchronized) data structures are replaced with a single new class to simplify any future additions and prevent the possibility of the data structures somehow getting out of sync.
@potuik - This is the previously-postponed second half of #25224 if you care to check out where that went.