Skip to content

Conversation

@ferruzzi
Copy link
Contributor

Follows the template set forward in #24643

Also cleans up and makes some required changes within the SystemTestContextBuilder to account for occasionally needing to split the imported variables such as a list of Subnets in this test.

@ferruzzi
Copy link
Contributor Author

ferruzzi commented Jul 21, 2022

Huh. Where did those come from.... 👀

Looks like the same tests are failing in main, so it's something that was changed in the last couple of days. I'm heading out for a mini roadtrip with the family, I'll try to figure this out on Monday if it's still a problem.

@potiuk
Copy link
Member

potiuk commented Jul 21, 2022

Huh. Where did those come from.... 👀

Looks like the same tests are failing in main, so it's something that was changed in the last couple of days. I'm heading out for a mini roadtrip with the family, I'll try to figure this out on Monday if it's still a problem.

have a great trip - nope. it looks like error when importing the tests :). But it can easily wait - no problem whatsoever :)

@ferruzzi
Copy link
Contributor Author

ferruzzi commented Jul 25, 2022

nope. it looks like error when importing the tests :).

Yeah, what I meant by that is when I rebase and check out main, those tests still fail. So we know:

  1. The cause is not something in this PR since it's also failing locally on the main branch.
  2. They were all passing when they were merged or we'd have seen this before.
  3. They were all passing locally before I rebased, which means whatever changed and broke them was early last week between my last two rebases.

Anyway, I'm home and I'll poke it today and see what I can find. 👍

[EDIT] Actually, I just rebased and these are all passing locally again on main when I run the same CI script but not in this branch. I'm quite confused by that, but but at least I know the issue is actually in this PR somewhere.

@ferruzzi ferruzzi force-pushed the ferruzzi/system-tests/fargate branch from a7f74c1 to 3667f6b Compare July 25, 2022 21:42
@ferruzzi
Copy link
Contributor Author

Closing while I sort this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants