Migrate amazon provider sensor tests from unittests to pytest
#28139
Conversation
boring-cyborg
bot
added
area:providers
provider:amazon
|
Nice 👍 Could you also replace |
Taragolis
left a comment
Taragolis
left a comment
There was a problem hiding this comment.
For me looking good. But might be @ferruzzi @vandonr-amz @o-nikolas @vincbeck have some comments
ferruzzi
left a comment
ferruzzi
left a comment
There was a problem hiding this comment.
Left one nitpick, but looks good. Thank you both for doing these, it's something I've been thinking about for a while
| def test_poke_on_success_state(self, mock_get_job_description): | ||
| mock_get_job_description.return_value = {"status": "SUCCEEDED"} | ||
| self.assertTrue(self.batch_sensor.poke({})) | ||
| assert self.batch_sensor.poke({}) |
There was a problem hiding this comment.
Non-blocking suggestion: missed one is True here
There was a problem hiding this comment.
Ahhh dang.
I included this change here: 9960d43
There was a problem hiding this comment.
Jarek sniped me on the merge, but it's all good. It's a minor thing.
…28145) Related: #28039 #28139 Migrate Amazon provider's transfer tests to `pytest`. All changes are more or less straightforward: - Get rid of unittests.TestCase class and TestCase.assert* methods - Convert setUp* and tearDown* methods to appropriate pytest alternative - Replace decorator `parameterized.expand` by `pytest.mark.parametrize`. - Renamed `@patch` to `@mock.patch` to conform to other tests
6 participants
Related: #28039 @Taragolis
Migrate Amazon provider's sensors and utils tests to
pytest.All changes are more or less straightforward:
parameterized.expandbypytest.mark.parametrize.