Migrate amazon provider transfer tests from unittests to pytest
#28145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
uranusjr
approved these changes
Dec 6, 2022
Member
|
some tests failing :( |
Taragolis
reviewed
Dec 6, 2022
Taragolis
reviewed
Dec 6, 2022
IAL32
commented
Dec 6, 2022
| def test_poke_on_success_state(self, mock_get_job_description): | ||
| mock_get_job_description.return_value = {"status": "SUCCEEDED"} | ||
| assert self.batch_sensor.poke({}) | ||
| assert self.batch_sensor.poke({}) is True |
Contributor
Author
There was a problem hiding this comment.
Small nitpick from @ferruzzi :
#28139 (review)
Contributor
There was a problem hiding this comment.
Thanks for including it here. 👍
ferruzzi
approved these changes
Dec 7, 2022
Contributor
ferruzzi
left a comment
ferruzzi
left a comment
There was a problem hiding this comment.
LGTM. These are a big help, thanks for taking them on!
Taragolis
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #28039 #28139 @Taragolis
Migrate Amazon provider's transfer tests to
pytest.All changes are more or less straightforward:
parameterized.expandbypytest.mark.parametrize.@patchto@mock.patchto conform to other tests