-
Notifications
You must be signed in to change notification settings - Fork 16.4k
KubernetesResourceOperator - KubernetesDeleteResourceOperator & KubernetesCreateResourceOperator #29930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KubernetesResourceOperator - KubernetesDeleteResourceOperator & KubernetesCreateResourceOperator #29930
Conversation
|
I'm hesitant to build create/deletes for every single resource type... Especially if you are going to ask them to give you it all via yaml anyways. Check out create_from_yaml instead. We could probably use this to build a generic create/delete? |
877ca52 to
a38400f
Compare
|
missing delete_from_yaml : kubernetes-client/python#940 |
|
inspired from tomplus/kubernetes_asyncio#239 |
|
errors to fix :( |
5941a59 to
67ff8ba
Compare
67ff8ba to
54369fe
Compare
54369fe to
6dd9f56
Compare
|
hey @potiuk I think I fixed the issues related to the PR , could you have a second look , thanks 👍 |
6dd9f56 to
0c5ee37
Compare
|
@jedcunningham thanks for your first review , could you have a second look to the PR , thanks |
potiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That one looks good to me. @jedcunningham ?
0c5ee37 to
b4b173e
Compare
|
just rebased on main branch |
tests/system/providers/cncf/kubernetes/example_kubernetes_resource.py
Outdated
Show resolved
Hide resolved
tests/system/providers/cncf/kubernetes/example_kubernetes_resource.py
Outdated
Show resolved
Hide resolved
|
Tests failing :( |
122770a to
b08e010
Compare
|
flaky test related to #30831 |
3e29034 to
f48fb68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - @jedcunningham ?
f48fb68 to
5c051a6
Compare
|
@eladkal thank again for your review , I adressed all your remarks , could you please re-review , thanks |
d0da0c1 to
c483970
Compare
|
@jedcunningham could you review again , thank you |
127361f to
9d64713
Compare
9d64713 to
ace319f
Compare
hussein-awala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! LGTM
|
@jedcunningham any further comments? |
tests/system/providers/cncf/kubernetes/example_kubernetes_resource.py
Outdated
Show resolved
Hide resolved
tests/system/providers/cncf/kubernetes/example_kubernetes_resource.py
Outdated
Show resolved
Hide resolved
tests/system/providers/cncf/kubernetes/example_kubernetes_resource.py
Outdated
Show resolved
Hide resolved
tests/system/providers/cncf/kubernetes/example_kubernetes_resource.py
Outdated
Show resolved
Hide resolved
tests/system/providers/cncf/kubernetes/example_kubernetes_resource.py
Outdated
Show resolved
Hide resolved
|
@potiuk could we merge ? Thanks |
Add an abstract KubernetesResourceOperator
and two concrete operators : KubernetesDeleteResourceOperator and KubernetesCreateResourceOperator
missing documentation and tests
example of use