Only run mssql tests on self-hosted runners #30831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MSSQL tests are rather flaky on public runners. They also almost never bring any extra value when fail usually those are flaky behaviour of MSSQL database for those runners due to resource constraints. This PR changes MSSQL tests to be only run for self-hosted runners, which means that they will be run for PRs of committers and in canary builds. This should be enough to find out potentially mssql-only breaking changes and fix them - without disturbing regular contributors.
hussein-awala
approved these changes
Apr 24, 2023
eladkal
added
the
changelog:skip
potiuk
added a commit
that referenced
this pull request
Jun 9, 2023
The MSSQL tests are rather flaky on public runners. They also almost never bring any extra value when fail usually those are flaky behaviour of MSSQL database for those runners due to resource constraints. This PR changes MSSQL tests to be only run for self-hosted runners, which means that they will be run for PRs of committers and in canary builds. This should be enough to find out potentially mssql-only breaking changes and fix them - without disturbing regular contributors. (cherry picked from commit 6e80bcd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MSSQL tests are rather flaky on public runners. They also almost never bring any extra value when fail usually those are flaky behaviour of MSSQL database for those runners due to resource constraints.
This PR changes MSSQL tests to be only run for self-hosted runners, which means that they will be run for PRs of committers and in canary builds.
This should be enough to find out potentially mssql-only breaking changes and fix them - without disturbing regular contributors.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.