Fix `QuickSightHook` bug on wait_for_state() function #30637

AkshatJoshi-18 · 2023-04-14T04:40:27Z

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

boring-cyborg · 2023-04-14T04:40:30Z

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
Be sure to read the Airflow Coding style.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

ssulca · 2023-04-14T12:55:12Z

airflow/providers/amazon/aws/hooks/quicksight.py

            self.log.info("Current status is %s", status)
-            if status in self.FAILED_STATES:
+            status = self.get_status(aws_account_id, data_set_id, ingestion_id)
+             if status in self.FAILED_STATES:


here, there is an indentation error

Thank for help.

potiuk · 2023-04-14T16:08:03Z

airflow/providers/amazon/aws/hooks/quicksight.py

-            time.sleep(check_interval)
-            sec += check_interval
-            status = self.get_status(aws_account_id, data_set_id, ingestion_id)
+        # wait and try again


The indentation is really wrong here.

airflow/providers/amazon/aws/hooks/quicksight.py

github-actions · 2023-05-30T00:12:02Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>

airflow/providers/amazon/aws/hooks/quicksight.py

More fixes for PR

o-nikolas · 2023-06-01T20:41:57Z

I've retried the build several times now with fresh main, but every time the jobs fail immediately with the GH error "This job failed", no logs at all to debug with.
@potiuk any ideas what's happening here or what I can do to debug further?

potiuk · 2023-06-05T00:01:44Z

Just rebased it to see. Could be a temporary github problem.

potiuk · 2023-06-05T00:09:00Z

BTW. If you want to debug it, I do not have more tools than anyone else. It's just regular gihub docs/info. Usually "job failed" (but this is just observation, I have no other tools to verify it) means that something is wrong on github side. The "Job failed" has exactly "0" indication (as you noticed) of what's going on,

But the right tool to help in the future, if we see jobs consistently failing is that any committer can open an issue to github https://support.github.com/ where there is a "other issue" or "report a bug" section when you can open an issue to GitHub support. You can choose "ASF Enterprise" level support and if you do, and describe the problem they usually answer in few hours.

o-nikolas · 2023-06-05T19:11:29Z

BTW. If you want to debug it, I do not have more tools than anyone else. It's just regular gihub docs/info.

Yupp, I know, but you've been working particularly close with Github Actions/CI longer than I have, so you have many tips, tricks and knowledge that I don't

But the right tool to help in the future, if we see jobs consistently failing is that any committer can open an issue to github https://support.github.com/ where there is a "other issue" or "report a bug" section when you can open an issue to GitHub support. You can choose "ASF Enterprise" level support and if you do, and describe the problem they usually answer in few hours.

And this proves my point 😆 I had no idea that we could do this, thanks for the tip. I'll try build this a few more times and if it doesn't unstick itself I'll open a ticket 😃

potiuk · 2023-06-07T21:47:18Z

I honestly, have no idea what's up with this one - I can't even rebase it any more. Opening it from scratch is probably a good idea.

potiuk · 2023-06-08T12:13:14Z

Ok @o-nikolas @AkshatJoshi-18 I think I know what could have caused it - > can you please REBASE it instead of retrying the build and let me know (For some reason I cannot rebase it any more @AkshatJoshi-18 - maybe you can rebase it again?)

AkshatJoshi-18 · 2023-06-08T12:33:06Z

Ok @o-nikolas @AkshatJoshi-18 I think I know what could have caused it - > can you please REBASE it instead of retrying the build and let me know (For some reason I cannot rebase it any more @AkshatJoshi-18 - maybe you can rebase it again?)

ok i will try :)

potiuk · 2023-06-08T13:12:45Z

BTW. I think I have a fix for similar case in #31792

o-nikolas · 2023-06-08T18:29:41Z

BTW. I think I have a fix for similar case in #31792

Nice!

@AkshatJoshi-18 can you re-open a PR with the changes that remained in this one?

AkshatJoshi-18 · 2023-06-08T18:56:11Z

@o-nikolas The repository that submitted this pull request has been deleted.

o-nikolas · 2023-06-08T18:59:29Z

@o-nikolas The repository that submitted this pull request has been deleted.

Yes, you'll need to re-create a fork and the changes :)

But if you're withdrawing yourself from this task that's also fine!

AkshatJoshi-18 · 2023-06-08T19:07:59Z

@o-nikolas I think ! the second option will be great for you guys :) because i created a lot of mess for you people 😅 . so I guess i will withdrawing myself :)

o-nikolas · 2023-06-08T19:15:43Z

Sounds good, and no worries, hopefully we see you around again soon!

Update quicksight.py

415a418

AkshatJoshi-18 requested review from eladkal and o-nikolas as code owners April 14, 2023 04:40

boring-cyborg bot added area:providers provider:amazon AWS/Amazon - related issues labels Apr 14, 2023

eladkal changed the title ~~Update quicksight.py / QuickSightHook bug on wait_for_state() function: #30626~~ Fix QuickSightHook bug on wait_for_state() function Apr 14, 2023

Merge branch 'main' into main

490d5c8

ssulca reviewed Apr 14, 2023

View reviewed changes

AkshatJoshi-18 and others added 3 commits April 14, 2023 21:14

Merge branch 'main' into main

80e4bcb

Fix QuickSightHook bug on wait_for_state() function #30637

0f0fa82

Merge branch 'main' of https://github.com/AkshatJoshi-18/airflow

581bb63

potiuk reviewed Apr 14, 2023

View reviewed changes

vincbeck requested changes Apr 14, 2023

View reviewed changes

airflow/providers/amazon/aws/hooks/quicksight.py Outdated Show resolved Hide resolved

github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label May 30, 2023

Update airflow/providers/amazon/aws/hooks/quicksight.py

fe199e6

Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>

o-nikolas reviewed May 30, 2023

View reviewed changes

airflow/providers/amazon/aws/hooks/quicksight.py Outdated Show resolved Hide resolved

airflow/providers/amazon/aws/hooks/quicksight.py Outdated Show resolved Hide resolved

github-actions bot removed the stale Stale PRs per the .github/workflows/stale.yml policy file label May 31, 2023

o-nikolas added 3 commits May 31, 2023 11:10

Apply suggestions from code review

b3041a0

More fixes for PR

Merge branch 'main' into main

8483d04

Merge branch 'main' into main

c28dceb

Merge branch 'main' into main

f655a07

Merge branch 'main' into main

49f5412

potiuk added the use public runners Makes sure that Public runners are used even if commiters creates the PR (useful for testing) label Jun 8, 2023

Merge branch 'main' into main

afec9bc

AkshatJoshi-18 closed this Jun 8, 2023

AkshatJoshi-18 reopened this Jun 8, 2023

AkshatJoshi-18 closed this by deleting the head repository Jun 8, 2023

potiuk mentioned this pull request Jun 8, 2023

Fix re-running failed jobs by committers without rebase #31792

Merged

o-nikolas mentioned this pull request Jun 8, 2023

Fetch status in while loop so as to not exit too early #31804

Merged

Fix QuickSightHook bug on wait_for_state() function #30637

Fix QuickSightHook bug on wait_for_state() function #30637

Uh oh!

Conversation

AkshatJoshi-18 commented Apr 14, 2023 • edited by eladkal Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

boring-cyborg bot commented Apr 14, 2023

Uh oh!

ssulca Apr 14, 2023

Choose a reason for hiding this comment

Uh oh!

AkshatJoshi-18 Apr 14, 2023

Choose a reason for hiding this comment

Uh oh!

potiuk Apr 14, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented May 30, 2023

Uh oh!

Uh oh!

Uh oh!

o-nikolas commented Jun 1, 2023

Uh oh!

potiuk commented Jun 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

potiuk commented Jun 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

o-nikolas commented Jun 5, 2023

Uh oh!

potiuk commented Jun 7, 2023

Uh oh!

potiuk commented Jun 8, 2023

Uh oh!

AkshatJoshi-18 commented Jun 8, 2023

Uh oh!

potiuk commented Jun 8, 2023

Uh oh!

o-nikolas commented Jun 8, 2023

Uh oh!

AkshatJoshi-18 commented Jun 8, 2023

Uh oh!

o-nikolas commented Jun 8, 2023

Uh oh!

AkshatJoshi-18 commented Jun 8, 2023

Uh oh!

o-nikolas commented Jun 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Fix `QuickSightHook` bug on wait_for_state() function #30637

Fix `QuickSightHook` bug on wait_for_state() function #30637

AkshatJoshi-18 commented Apr 14, 2023 •

edited by eladkal

Loading

potiuk commented Jun 5, 2023 •

edited

Loading

potiuk commented Jun 5, 2023 •

edited

Loading