Fetch status in while loop so as to not exit too early #31804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
eladkal
approved these changes
Jun 8, 2023
Contributor
eladkal
left a comment
eladkal
left a comment
There was a problem hiding this comment.
Is it possible to have unit test covering it?
hoping to avoid future regression
Contributor
Author
vincbeck
approved these changes
Jun 8, 2023
Contributor
Author
Let me look and see 👍 |
This fixes a condition described in apache#30626 for the AWS Quicksight hook
o-nikolas
force-pushed
the
onikolas/quicksight_wait_for_state
branch
from
1cdecb1 to
0977b87
Compare
Contributor
Author
|
Added a test case to cover this @eladkal |
vincbeck
approved these changes
Jun 8, 2023
potiuk
approved these changes
Jun 8, 2023
86 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a condition described in #30626 for the AWS Quicksight hook.
There was a previous PR #30637 which is now closed, so I'm submitting what was left of those changes here.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.