Speed up package wheel job in CI #30766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
changed the title
eladkal
approved these changes
Apr 20, 2023
vincbeck
approved these changes
Apr 20, 2023
After recent improvements, package wheel job has become one of the longest jobs to run. So far it sequentially build airlfow, prepared documentation for packages, build the packages installed both airflow and packages and tested imports for them, then it was removing installed airlfow, removed airflow and run the same tests with 2.3 airflow version to check for compatibility. This change splits it into two parallel jobs. There is a small duplication (3 minutes of preparing the whl packages) but then the "compatibility" job does not need Airflow and few other steps to be run (such as preparing docs or airlfow) and overall we just get few minutes longer to repeate the wheel package preparation but then each of the two jobs will take a bit more than half the time of the original way, which will greately improve feedback time for the users (in most cases the two jobs will complete under 12 minutes, where the original job needed 21 minutes to complete.
potiuk
force-pushed
the
speed-up-provider-package-wheel-check
branch
from
794e1c4 to
bc4f00f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After recent improvements, package wheel job has become one
of the longest jobs to run. So far it sequentially build airlfow,
prepared documentation for packages, build the packages
installed both airflow and packages and tested imports for them, then it
was removing installed airlfow, removed airflow and run the same tests
with 2.3 airflow version to check for compatibility.
This change splits it into two parallel jobs. There is a small
duplication (3 minutes of preparing the whl packages) but then
the "compatibility" job does not need Airflow and few other
steps to be run (such as preparing docs or airlfow) and overall
we just get few minutes longer to repeate the wheel package
preparation but then each of the two jobs will take a bit more
than half the time of the original way, which will greately improve
feedback time for the users (in most cases the two jobs will complete
under 12 minutes, where the original job needed 21 minutes to complete.
Based on #29223 so only last commit counts
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.