BaseAWS - Override client when resource_type is user to get custom waiters #30897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
Contributor
|
CC @ferruzzi |
ferruzzi
approved these changes
Apr 27, 2023
Contributor
ferruzzi
left a comment
ferruzzi
left a comment
There was a problem hiding this comment.
Nice! Thanks for submitting this. Looks good to me. I assume you tried it out with your new DynamoDB waiter?
Contributor
Author
|
@ferruzzi Yes, tested it. :) |
potiuk
approved these changes
Apr 28, 2023
80 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, in the BaseAWS hook, the custom waiter doesn't work with resource_type, only client_type is supported. In this PR we are overriding the client when the user uses resource_type's hooks with boto3.client(). This PR temporarily fixes the issue on the Airflow side, until it is not fixed in Botocore.