Skip to content

Conversation

@ChaotX
Copy link

@ChaotX ChaotX commented May 2, 2023

Fix extra fields used as headers

Fix extra fields used as headers
@boring-cyborg
Copy link

boring-cyborg bot commented May 2, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@ChaotX
Copy link
Author

ChaotX commented May 2, 2023

@sunank200 Can you please take a look at this? I think this was just a typo.

Copy link
Member

@pankajastro pankajastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@potiuk
Copy link
Member

potiuk commented May 2, 2023

We should add/update test for it. One of the reasons it did not work here was that either test was wrong or missing.

Copy link
Collaborator

@sunank200 sunank200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChaotX can you add the test for the change, please as @potiuk mentioned before we merge this PR?

@ChaotX
Copy link
Author

ChaotX commented May 3, 2023

I have no clue how to do that. Figuring it out would take too much time for me. I just started this with a one character fix...

@potiuk
Copy link
Member

potiuk commented May 3, 2023

I have no clue how to do that. Figuring it out would take too much time for me. I just started this with a one character fix...

Happy to guide you if you want. If not, then maybe somone looking here will help and add it. but generally we do not merge a change where tests do not fail before and do not fail after, because we have no way to verify it and keep it verified in the future versions.

@potiuk
Copy link
Member

potiuk commented May 3, 2023

I marked it with "good first issue" which usually indicates to people that things are up for grabs and if you won't add tests, hopefully it will drag attentions of those who can add it (though we rarely do that for PRs)

@pankajastro
Copy link
Member

pankajastro commented May 4, 2023

You can find http-related tests https://github.com/apache/airflow/tree/main/tests/providers/http and we are using pytest so probably you will have to add a test in https://github.com/apache/airflow/blob/main/tests/providers/http/hooks/test_http.py

you can use pytest or breeze to run these tests on your local machine as well

@potiuk
Copy link
Member

potiuk commented May 8, 2023

Some fixes are needed.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Jun 23, 2023
@ChaotX
Copy link
Author

ChaotX commented Jun 23, 2023

@sunank200 Can you please help adding these test to your contribution? I had no time to figure out how to change the test env to 3.8+ python.

@github-actions github-actions bot removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Jun 24, 2023
@eladkal
Copy link
Contributor

eladkal commented Jul 6, 2023

Fixed in #32409

@eladkal eladkal closed this Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants