Fix headers passed into HttpAsyncHook #32409
Conversation
setup.cfg
Outdated
| markupsafe>=1.1.1 | ||
| marshmallow-oneofschema>=2.0.1 | ||
| mdit-py-plugins>=0.3.0 | ||
| mock>=5.0.2;python_version<="3.7" |
There was a problem hiding this comment.
We dont support Python 3.7 any longer.
If you check the test suite you will see it tests against 3.8 - 3.11
Where did you notice failure related to Python 3.7?
There was a problem hiding this comment.
In the stale PR https://github.com/apache/airflow/actions/runs/4885483415/jobs/8719703717?pr=31010
I understand Py 3.7 support will be dropped only in the next Airflow release, but I didn't realize the test suites have already dropped it, sorry about that.
I've reverted the Py 3.7 related changes.
There was a problem hiding this comment.
This is provider code :)
You can see in the change log that we already dropped support
https://airflow.apache.org/docs/apache-airflow-providers-github/stable/index.html#id1
Python 3.7 is relevant only for Airflow 2.6 releases
There was a problem hiding this comment.
Ah TIL, this is my first time contributing to Airflow, I've only been a user until now.
Thanks for the review 😄
This reverts commit d873c4c.
3 participants
This fixes the header value passed into the HttpAsyncHook and adds a test, and uses a backport of unittest.mock for AsyncMock usage in Python 3.7.
closes: #32390
replaces: #31010