Ensure that we check worker for served logs if no local or remote logs found #31101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s found Generally speaking when a task is done we should not read from logs server, because we assume for log persistence that users will either set up shared drive or enable remote logging. But if they don't do that, and therefore we don't find remote or local logs, we'll check worker for served logs as a fallback.
2 tasks
potiuk
reviewed
May 5, 2023
potiuk
approved these changes
May 5, 2023
Member
|
But just to warn you - I am up to refactoring that one soon as soon as we get out of the "let's fix teething problems of 2.6.0" mode :) |
Contributor
Author
I'm eager to help with it! |
jedcunningham
approved these changes
May 5, 2023
2 tasks
pankajkoti
approved these changes
May 6, 2023
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
ephraimbuddy
pushed a commit
that referenced
this pull request
May 9, 2023
…s found (#31101) Generally speaking when a task is done we should not read from logs server, because we assume for log persistence that users will either set up shared drive or enable remote logging. But if they don't do that, and therefore we don't find remote or local logs, we'll check worker for served logs as a fallback. Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com> (cherry picked from commit 672ee7f)
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally speaking when a task is done we should not read from logs server, because we assume for log persistence that users will either set up shared drive or enable remote logging. But if they don't do that, and therefore we don't find remote or local logs, we'll check worker for served logs as a fallback.
Resolves #31059
Possibly related #30997
Resolves #31083