Sync v2-6-stable with v2-6-test to release 2.6.1 #31133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 817f846)
The Airflow models have been accidentally removed from the docs when #28300 was implemented. The whole models documentation have been removed accidentally, even if there were references to the actual classes and packages used as the models package was entirely excluded. This PR fixes it by selectively including the models that should be included and by linking the package indexes directly in the public interface documentation. (cherry picked from commit 6720a90)
* Add missing changelog in 2.6.0 * Update RELEASE_NOTES.rst Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com> * fixup! Add missing changelog in 2.6.0 --------- Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com> (cherry picked from commit ea18edb)
(cherry picked from commit 070ecbd)
ephraimbuddy
requested review from
XD-DENG,
ashb,
bbovenzi,
dstandish,
eladkal,
jedcunningham,
jhtimmins,
kaxil,
o-nikolas,
potiuk,
ryanahamilton and
uranusjr
as code owners
boring-cyborg
bot
added
area:API
Contributor
|
#31125 is missing from the release |
Contributor
Author
|
Let me move it to 2.7.0. since it added a config. I accessed it by the issue it closed and didn't look the code change. It should be 2.7.0 |
raphaelauv
reviewed
May 8, 2023
This comment was marked as resolved.
This comment was marked as resolved.
Member
👑 |
Member
|
(Hmmm, no guillotine emoji. Shame) |
Contributor
|
I just merged #31101 and set its milestone back to 2.6.1 fyi |
Member
|
Here's my PR #31149 |
…in (#31149) The current published plugin calls `_redact_all` directly, so when we added the `max_depth` parameter in 2.6 (precisely so it didn't need to call this private function directly!) we broke that. This change leads to some worrying logs appearing in task logs for anyone with the plugin installed: ``` [2023-05-05, 11:56:17 BST] {utils.py:490} WARNING - Unable to redact []Error was: TypeError: SecretsMasker._redact_all() missing 1 required positional argument: 'max_depth' [2023-05-05, 11:56:17 BST] {utils.py:490} WARNING - Unable to redact []Error was: TypeError: SecretsMasker._redact_all() missing 1 required positional argument: 'max_depth' [2023-05-05, 11:56:17 BST] {utils.py:490} WARNING - Unable to redact NoneError was: TypeError: SecretsMasker._redact_all() missing 1 required positional argument: 'max_depth' ``` This patch makes that previous change backwards compatible for that with no change in behaviour for new code. (cherry picked from commit 25e3159)
(cherry picked from commit 433ed2c)
…s found (#31101) Generally speaking when a task is done we should not read from logs server, because we assume for log persistence that users will either set up shared drive or enable remote logging. But if they don't do that, and therefore we don't find remote or local logs, we'll check worker for served logs as a fallback. Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com> (cherry picked from commit 672ee7f)
potiuk
approved these changes
May 9, 2023
Contributor
this is not in release notes yet, or it shouldn't? |
pygithub now requires to specify if a search is for pull request or issues and not both. Also, a fix on searching old rc versions after removing the asf svn repo (cherry picked from commit 3d6ad50)
If you run a task via the cli with `cfg_path`, we also run `configure_vars` again so that the globals built from the config file can be updated. We were also initializing pluggy in that function, however, which was effectively removing any user provided hooks. We will move the initializing of pluggy out of that function, making it safe to run again by the task command. This primarily impacted KPOs, as they wouldn't have been passed through any `pod_mutation_hooks`. (cherry picked from commit 71c2627)
(cherry picked from commit 2890652)
ephraimbuddy
force-pushed
the
v2-6-test
branch
2 times, most recently
from
1938aed to
05d8d93
Compare
jedcunningham
approved these changes
May 10, 2023
(cherry picked from commit 86d62d3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time for
2.6.1rc1!