DynamoDBToS3Operator - change export_time value to utcnow() in system test #31307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
area:system-tests
provider:amazon
hussein-awala
approved these changes
May 16, 2023
vincbeck
requested changes
May 16, 2023
vincbeck
reviewed
May 16, 2023
Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
vincbeck
approved these changes
May 16, 2023
ferruzzi
approved these changes
May 16, 2023
Contributor
Author
|
@vincbeck @ferruzzi Can anyone please confirm if this fix worked? Took a look at the dashboard - https://aws-mwaa.github.io/open-source/system-tests/dashboard.html didn't see it green for |
Contributor
|
It did not. One of the reason it worked on your environment and not ours is #31333. Now, we still have another issue. I am working on it and will ping you when I have a PR ready |
Contributor
Author
|
@vincbeck Thanks for the response. I see, sure please share when the PR is ready, would love to take a look. Also, please let me know if I can be of any help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since datetime.now() returns the local time which can cause issues while running tests from different timezones, replacing it with datetime.utcnow().
cc: @vincbeck @ferruzzi @o-nikolas