Fix AWS system test example_dynamodb_to_s3 #31362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
area:system-tests
provider:amazon
Contributor
Author
ferruzzi
approved these changes
May 17, 2023
| TableName=table_name, | ||
| ) | ||
|
|
||
| return r["ContinuousBackupsDescription"]["PointInTimeRecoveryDescription"]["EarliestRestorableDateTime"] |
Contributor
There was a problem hiding this comment.
Oh, that's nicer than my created time idea. Nice find.
Contributor
There was a problem hiding this comment.
This looks good! thanks for taking care of this.
| def _export_entire_data(self): | ||
| """Export all data from the table.""" | ||
| table = self.hook.get_conn().Table(self.dynamodb_table_name) | ||
| table = self.hook.conn.Table(self.dynamodb_table_name) |
Comment on lines
+100
to
+107
| "dynamodb_table_name", | ||
| "s3_bucket_name", | ||
| "file_size", | ||
| "dynamodb_scan_kwargs", | ||
| "s3_key_prefix", | ||
| "dynamodb_table_name", | ||
| "process_func", | ||
| "export_time", | ||
| "export_format", |
Contributor
|
One of your unit tests are failing, bit otherwise LGTM. Some nice nitpick catches in there as well, thanks for those. |
utkarsharma2
approved these changes
May 17, 2023
Contributor
|
@vincbeck Thanks for handling the timezone scenario as well. LGTM :) |
potiuk
approved these changes
May 17, 2023
Member
|
(Approved - pending the unit-test fix :) |
Contributor
Author
|
All green :) |
Contributor
Author
|
:D
|
Member
|
🎉 🎉 🎉 🎉 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The system test
example_dynamodb_to_s3is currently failing for multiple reasons:describe_continuous_backupsAPI.See related: #31307
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.