Add rich-click options to check if the Breeze images should be generated #32523
Conversation
potiuk
requested review from
amoghrajesh,
ephraimbuddy,
pankajastro,
pankajkoti,
utkarsharma2 and
vincbeck
|
Small life quality improvements for those who modify / add new breeze images @amoghrajesh -> this one will ask you to regenerate images for #32495 (previously it would not ask to regenerate screenshots if you have only updated |
|
BTW. The changed images are because I have not yet figured out the differences on Mac and Linux. There is a slight difference between the screenshots generated on those which I have no idea where they come from - this is not a big issue and it's ok to get some images generated on either, but maybe some day we will fix it. All the images willl now generated on Linux after this one is merged. |
potiuk
force-pushed
the
add-option-groups-to-command-hashes
branch
2 times, most recently
from
5297570 to
59ad2f5
Compare
So far, only list of flags and their details have been used to determine if the screenshots of Breeze commands should be regenerated (by calculating hash of those options). However also rich-click options determine the look of those screenshots (by grouping options together) so change in the options should also be included in hash generation. This change combines the dict of click options for each command with the rich-click options into a single dictionary and hashes them together - this way any time any of those parameters change, the image will need to be regenerated.
potiuk
force-pushed
the
add-option-groups-to-command-hashes
branch
from
59ad2f5 to
f0ba6af
Compare
|
And nice error in case you add new command and it is missing in rich-click options:
|
The recent "add-back-references" command was not added to group to nicely show it in `release-management --help` output. This PR fixes it, and at the same time it turned out that similarly as in subcommands fixed in apache#32523, hash of command did not include options, so when **just** options were changed, the images were not marked as needing regeneration. Adding options to hash calculation solves the problem.
3 participants
So far, only list of flags and their details have been used to determine if the screenshots of Breeze commands should be regenerated (by calculating hash of those options). However also rich-click options determine the look of those screenshots (by grouping options together) so change in the options should also be included in hash generation.
This change combines the dict of click options for each command with the rich-click options into a single dictionary and hashes them together - this way any time any of those parameters change, the image will need to be regenerated.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.