Add regeneration of breeze help images on commmand option changes. #32624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent "add-back-references" command was not added to group to nicely show it in `release-management --help` output. This PR fixes it, and at the same time it turned out that similarly as in subcommands fixed in apache#32523, hash of command did not include options, so when **just** options were changed, the images were not marked as needing regeneration. Adding options to hash calculation solves the problem.
hussein-awala
approved these changes
Jul 15, 2023
amoghrajesh
approved these changes
Jul 15, 2023
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
Thanks for fixing this. Looks good +1
uranusjr
approved these changes
Jul 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent "add-back-references" command was not added to group to nicely show it in
release-management --helpoutput. This PR fixes it, and at the same time it turned out that similarly as in subcommands fixed in #32523, hash of command did not include options, so when just options were changed, the images were not marked as needing regeneration.Adding options to hash calculation solves the problem.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.