Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Jul 31, 2023

We have an automated system-test pytest marker that applies the pytest.mark.system marker to all system tests. It has been implemented in a strange way as it was applying the marker to all provider tests if the whole "tests" directory was used for test collection.

This caused quarantine tests from providers folder to be skipped because they were automatically marked with pytest.mark.system marker.

Also system tests were generally excluded from running after we brought back the "test_*" prefix.

This PR updates the auto-marker to only apply system marker to tests in "system/providers" folder and adds the "example_*" prefix to the prefixes automatically collected by pytest.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

We have an automated system-test pytest marker that applies the
pytest.mark.system marker to all system tests. It has been implemented
in a strange way as it was applying the marker to all provider tests
if the whole "tests" directory was used for test collection.

This caused quarantine tests from providers folder to be skipped
because they were automatically marked with pytest.mark.system marker.

Also system tests were generally excluded from running after we brought
back the "test_*" prefix.

This PR updates the auto-marker to only apply system marker to
tests in "system/providers" folder and adds the "example_*" prefix
to the prefixes automatically collected by pytest.
@potiuk
Copy link
Member Author

potiuk commented Jul 31, 2023

cc: @VladaZakharova @ferruzzi -> You might be interested in this one, the system tests were not collected automaticaly, but now they should be collected when you run the whole folder pytest tests/system/providers/aws or `pytest tests/system/providers/google' should run all the tests for respective provider.

@ferruzzi ferruzzi merged commit 11629f6 into apache:main Jul 31, 2023
potiuk added a commit to potiuk/airflow that referenced this pull request Jul 31, 2023
The test - when collected - throws Airflow Exception. This has
been revealed by apache#32978
potiuk added a commit that referenced this pull request Jul 31, 2023
The test - when collected - throws Airflow Exception. This has
been revealed by #32978
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Aug 2, 2023
@potiuk potiuk deleted the fix-auto-system-marker branch November 17, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:system-tests changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants