Move redis subscribe to poke() method in Redis Sensor #32984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
revealed after #32978 |
ferruzzi
approved these changes
Jul 31, 2023
potiuk
force-pushed
the
move-redis-subscribe-to-poke-in-redis-sensor
branch
from
29fbbb5 to
e1bd4d8
Compare
Member
Author
|
Actually the integration test needed to be fixed too @ferruzzi -> the problem was that the way it was constructed, the test actually depended on first subscribing in init(), then publishing and then poke(). I had to update it a bit and make sure that we do not re-subscribe if we already run poke() in the same active sensor task. Now it should be fine. |
Contributor
|
Sounds good, I'll take another look. |
Contributor
|
Interesting. It's a shame subscribe() didn't return a value you could have used instead of creating an new field, but oh well. re-approved; CI is green |
In RedisPubSubSensor subscription has been done in constructor, which was pretty wrong - for example it means that when scheduler parses the sensor, it involves subscribing to the messages and commmunication with redis DB. This PR moves subscription to "poke()" method, which is executed on worker instead.
potiuk
force-pushed
the
move-redis-subscribe-to-poke-in-redis-sensor
branch
from
e1bd4d8 to
1f2b72b
Compare
hussein-awala
approved these changes
Jul 31, 2023
Contributor
|
Not that my approval means much at this point, but Approved? Again? |
44 tasks
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Aug 5, 2023
The fix in apache#32984 moved redis hook to be initialized in a cached property but "subscription" call has been moved to the poke - which would cause multiple subscribe calls in regular mode of the sensor (i.e. not poke-reschedule mode). This one fixes it by subscribing only once - when the cached property gets initialized. Fixes: apache#33138
potiuk
added a commit
that referenced
this pull request
Aug 5, 2023
The fix in #32984 moved redis hook to be initialized in a cached property but "subscription" call has been moved to the poke - which would cause multiple subscribe calls in regular mode of the sensor (i.e. not poke-reschedule mode). This one fixes it by subscribing only once - when the cached property gets initialized. Fixes: #33138
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In RedisPubSubSensor subscription has been done in constructor, which was pretty wrong - for example it means that when scheduler parses the sensor, it involves subscribing to the messages and commmunication with redis DB.
This PR moves subscription to "poke()" method, which is executed on worker instead.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.