Fix oversubsription of Redis pubsub sensor #33139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix in apache#32984 moved redis hook to be initialized in a cached property but "subscription" call has been moved to the poke - which would cause multiple subscribe calls in regular mode of the sensor (i.e. not poke-reschedule mode). This one fixes it by subscribing only once - when the cached property gets initialized. Fixes: apache#33138
hussein-awala
approved these changes
Aug 5, 2023
eladkal
approved these changes
Aug 5, 2023
This was referenced Aug 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix in #32984 moved redis hook to be initialized in a cached property but "subscription" call has been moved to the poke - which would cause multiple subscribe calls in regular mode of the sensor (i.e. not poke-reschedule mode).
This one fixes it by subscribing only once - when the cached property gets initialized.
Fixes: #33138
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.