Alias DATAPROC_JOB_LOG_LINK to DATAPROC_JOB_LINK
#33148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DATAPROC_JOB_LINK was DATAPROC_JOB_LOG_LINK. This renaming breaks backward compatibility. Thus, adding an alias for fixing it.
boring-cyborg
bot
added
area:providers
provider:google
phanikumv
approved these changes
Aug 6, 2023
eladkal
requested changes
Aug 6, 2023
44 tasks
potiuk
approved these changes
Aug 6, 2023
…_LINK alias in the next major release
eladkal
changed the title
DATAPROC_JOB_LOG_LINK to DATAPROC_JOB_LINK
eladkal
approved these changes
Aug 7, 2023
potiuk
reviewed
Aug 7, 2023
|
|
||
| DATAPROC_BASE_LINK = BASE_LINK + "/dataproc" | ||
| DATAPROC_JOB_LINK = DATAPROC_BASE_LINK + "/jobs/{job_id}?region={region}&project={project_id}" | ||
| # TODO: remove DATAPROC_JOB_LOG_LINK alias in the next major release |
Member
There was a problem hiding this comment.
One (post merge) comment - I think we should not remove it in the next major release if we do not do deprecation warning when it is used. The user will have no warnings whatsoever if we do.
Member
Author
There was a problem hiding this comment.
Sure. I tried to add the warning through #33189 (the way how DATAPROC_JOB_LOG_LINK is mapped to DATAPROC_JOB_LINK has been changed as well)
This was referenced Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DATAPROC_JOB_LINK was DATAPROC_JOB_LOG_LINK. This renaming breaks backward compatibility. Thus, adding an alias for fixing it.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.