Skip to content

Conversation

@Lee-W
Copy link
Member

@Lee-W Lee-W commented Aug 8, 2023

use module level __getattr__ for mapping DATAPROC_JOB_LOG_LINK to DATAPROC_JOB_LINK and add deprecation warning

related #33148


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Aug 8, 2023
@Lee-W Lee-W changed the title use module level __getattr__ for mapping DATAPROCJOB_LOG_LINK to DATAPROC_JOB_LINK and add deprecation warning add deprecation warning to DATAPROC_JOB_LOG_LINK Aug 8, 2023
…_JOB_LOG_LINK to DATAPROC_JOB_LINK and add deprecation warning
@Lee-W Lee-W force-pushed the deprecate-DATAPROC_JOB_LOG_LINK-through-pep-562 branch from e6fc1c8 to 7f99aee Compare August 8, 2023 07:43
@Lee-W Lee-W marked this pull request as ready for review August 8, 2023 07:43
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@potiuk potiuk merged commit e43206e into apache:main Aug 8, 2023
@potiuk
Copy link
Member

potiuk commented Aug 8, 2023

Pity it did not make it to RC2 :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants