Adding typing for KPO SCC objects #33381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoghrajesh
requested review from
hussein-awala and
jedcunningham
as code owners
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
Lee-W
approved these changes
Aug 14, 2023
hussein-awala
approved these changes
Aug 14, 2023
Member
hussein-awala
left a comment
hussein-awala
left a comment
There was a problem hiding this comment.
We should keep dict supported for backward compatibility
hussein-awala
added
the
use public runners
potiuk
approved these changes
Aug 14, 2023
Member
|
Nice! |
* Add Service Principal Oauth for Databricks. (apache#32969) * Consolidate OAuth validation and storage (apache#32969) * Formatting update and added API and Spark to Init Import * Update documentation with doc ref and note this is for AWS deployments
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 17, 2023
* Adding typing for KPO SCC objects --------- Co-authored-by: Hussein Awala <hussein@awala.fr> Co-authored-by: Wei Lee <weilee.rx@gmail.com> Co-authored-by: John Brandborg <john.brandborg@protonmail.com>
This was referenced Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some K8S objects used in airflow code do not use typing as recommended by the client code. Adding typing for SCC objects. Will create future PRs in case I find more of these.
Related old PR: #31275
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.