respect soft_fail argument when ExternalTaskSensor runs in deferrable mode #33196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lee-W
changed the title
uranusjr
reviewed
Aug 10, 2023
…askSensor runs in deferrable mode
Lee-W
force-pushed
the
respect-soft_fail-when-ExternalTaskSensor-run-in-deferrable-mode
branch
from
7fb0d8d to
d9c385f
Compare
uranusjr
reviewed
Aug 14, 2023
…eyword-only arguments
potiuk
approved these changes
Aug 14, 2023
amoghrajesh
pushed a commit
to amoghrajesh/airflow
that referenced
this pull request
Aug 14, 2023
This was referenced Aug 15, 2023
hussein-awala
added a commit
to hussein-awala/airflow
that referenced
this pull request
Aug 16, 2023
…ferrable mode (apache#33196)" This reverts commit a1b5bdb.
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 17, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 28, 2023
97 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We notice that not all the sensors respect soft_fail. This PR is meant to demonstrate how I'd like to address this issue. Will send PRs to fix other sensors when we finalize the way to fix it.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.