Respect "soft_fail" argument when "poke" is called #33401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lee-W
changed the title
soft_fail argument when poke is called
Lee-W
changed the title
soft_fail argument when poke is called
uranusjr
approved these changes
Aug 15, 2023
Lee-W
force-pushed
the
respect_soft_fail_argument_when_poke_is_called
branch
3 times, most recently
from
0ae94e4 to
89cf2e5
Compare
… True and exception occurs after running poke()
… other kinds of exception is raised
Lee-W
force-pushed
the
respect_soft_fail_argument_when_poke_is_called
branch
from
89cf2e5 to
6b144d5
Compare
potiuk
approved these changes
Aug 25, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 28, 2023
* feat(sensors/base): raise AirflowSkipException if soft_fail is set to True and exception occurs after running poke() * test(sensor/base): add test case for respecting soft_fail option when other kinds of exception is raised (cherry picked from commit d91c481)
97 tasks
This was referenced Sep 28, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the following PR to #33196 and intends to solve the issue that the
soft_failargument might not work on all sensors.This PR handles the case that non-AirflowSkipException is raised, but
soft_failis set to True.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.