Create a new method used to resume the task in order to implement specific logic for operators #33424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… specific logic for each operator
hussein-awala
requested review from
XD-DENG,
ashb,
kaxil and
uranusjr
as code owners
Member
Author
|
I will try to add a test tomorrow. |
uranusjr
reviewed
Aug 17, 2023
Lee-W
reviewed
Aug 17, 2023
uranusjr
reviewed
Aug 18, 2023
Member
uranusjr
left a comment
uranusjr
left a comment
There was a problem hiding this comment.
Mosly look good to me, just a couple of minor questions regarding exception handling
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
2 tasks
Lee-W
approved these changes
Aug 21, 2023
uranusjr
approved these changes
Aug 21, 2023
potiuk
approved these changes
Aug 21, 2023
Contributor
|
This doesn't look like it's a bug fix? |
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 28, 2023
…cific logic for operators (#33424) * Create a generic method used to resume the task in order to implement specific logic for each operator * Provide resume_execution args * add a unit test * Fix soft fail after a trigger timeout * wrap the exception with a str to get the message * Apply suggestions from code review Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> --------- Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> (cherry picked from commit 852f85b)
Lee-W
added a commit
to astronomer/airflow
that referenced
this pull request
Aug 31, 2023
97 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #33405
related: #33196
This PR creates a new method used by the TI to resume the execution, and moves handling the triggers errors to this method. In this way we can simplify handling the trigger result which should not be in TaskInstance, and implement specific processing for some operators.
With this solution we can easily handle the soft fail for all the sensors (the core operators, where we still need a solution for providers sensors when using an older version of Airflow).
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.