-
Notifications
You must be signed in to change notification settings - Fork 16.4k
feat(providers/microsoft): add DefaultAzureCredential support to AzureContainerInstanceHook #33467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pankajastro
merged 3 commits into
apache:main
from
astronomer:add-DefaultAzureCredential-support-to-AzureContainerInstanceHook
Aug 24, 2023
Merged
feat(providers/microsoft): add DefaultAzureCredential support to AzureContainerInstanceHook #33467
pankajastro
merged 3 commits into
apache:main
from
astronomer:add-DefaultAzureCredential-support-to-AzureContainerInstanceHook
Aug 24, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
… azure-python-sdk through AzureIdentityCredentialAdapter wrapper https://stackoverflow.com/questions/63384092/exception-attributeerror-defaultazurecredential-object-has-no-attribute-sig
…eContainerInstanceHook
… DefaultAzureCredential due to backward compatibility
e267423 to
aa37281
Compare
pankajastro
approved these changes
Aug 24, 2023
Member
pankajastro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Aug 25, 2023
Lee-W
added a commit
to astronomer/airflow
that referenced
this pull request
Sep 1, 2023
verify that AzureContainerInstanceHook use DefaultAzureCredential when other credential (i.e., login, password, tenant_id) are not provided apache#33467
eladkal
pushed a commit
that referenced
this pull request
Sep 1, 2023
…ok (#33991) * test(providers/microsoft): add test cases to AzureContainerInstanceHook verify that AzureContainerInstanceHook use DefaultAzureCredential when other credential (i.e., login, password, tenant_id) are not provided #33467 * test(providers/microsoft): improve test_get_conn_fallback_to_default_azure_credential by asserting return conn and called args * test: move marker disable_autouse to conftest * Revert "test: move marker disable_autouse to conftest" This reverts commit ad6c0f2. * test(providers/microsoft): move test_get_conn_fallback_to_default_azure_credential into a separate class * test: remove unnecessary marker
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jul 18, 2024
…ok (#33991) * test(providers/microsoft): add test cases to AzureContainerInstanceHook verify that AzureContainerInstanceHook use DefaultAzureCredential when other credential (i.e., login, password, tenant_id) are not provided apache/airflow#33467 * test(providers/microsoft): improve test_get_conn_fallback_to_default_azure_credential by asserting return conn and called args * test: move marker disable_autouse to conftest * Revert "test: move marker disable_autouse to conftest" This reverts commit ad6c0f2aaf700c6fc58852eede915fd04f8c6b37. * test(providers/microsoft): move test_get_conn_fallback_to_default_azure_credential into a separate class * test: remove unnecessary marker GitOrigin-RevId: 0fac318a9c9a776dc18f985de494aa253e22e820
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 20, 2024
…ok (#33991) * test(providers/microsoft): add test cases to AzureContainerInstanceHook verify that AzureContainerInstanceHook use DefaultAzureCredential when other credential (i.e., login, password, tenant_id) are not provided apache/airflow#33467 * test(providers/microsoft): improve test_get_conn_fallback_to_default_azure_credential by asserting return conn and called args * test: move marker disable_autouse to conftest * Revert "test: move marker disable_autouse to conftest" This reverts commit ad6c0f2aaf700c6fc58852eede915fd04f8c6b37. * test(providers/microsoft): move test_get_conn_fallback_to_default_azure_credential into a separate class * test: remove unnecessary marker GitOrigin-RevId: 0fac318a9c9a776dc18f985de494aa253e22e820
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Nov 8, 2024
…ok (#33991) * test(providers/microsoft): add test cases to AzureContainerInstanceHook verify that AzureContainerInstanceHook use DefaultAzureCredential when other credential (i.e., login, password, tenant_id) are not provided apache/airflow#33467 * test(providers/microsoft): improve test_get_conn_fallback_to_default_azure_credential by asserting return conn and called args * test: move marker disable_autouse to conftest * Revert "test: move marker disable_autouse to conftest" This reverts commit ad6c0f2aaf700c6fc58852eede915fd04f8c6b37. * test(providers/microsoft): move test_get_conn_fallback_to_default_azure_credential into a separate class * test: remove unnecessary marker GitOrigin-RevId: 0fac318a9c9a776dc18f985de494aa253e22e820
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
May 4, 2025
…ok (#33991) * test(providers/microsoft): add test cases to AzureContainerInstanceHook verify that AzureContainerInstanceHook use DefaultAzureCredential when other credential (i.e., login, password, tenant_id) are not provided apache/airflow#33467 * test(providers/microsoft): improve test_get_conn_fallback_to_default_azure_credential by asserting return conn and called args * test: move marker disable_autouse to conftest * Revert "test: move marker disable_autouse to conftest" This reverts commit ad6c0f2aaf700c6fc58852eede915fd04f8c6b37. * test(providers/microsoft): move test_get_conn_fallback_to_default_azure_credential into a separate class * test: remove unnecessary marker GitOrigin-RevId: 0fac318a9c9a776dc18f985de494aa253e22e820
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
May 25, 2025
…ok (#33991) * test(providers/microsoft): add test cases to AzureContainerInstanceHook verify that AzureContainerInstanceHook use DefaultAzureCredential when other credential (i.e., login, password, tenant_id) are not provided apache/airflow#33467 * test(providers/microsoft): improve test_get_conn_fallback_to_default_azure_credential by asserting return conn and called args * test: move marker disable_autouse to conftest * Revert "test: move marker disable_autouse to conftest" This reverts commit ad6c0f2aaf700c6fc58852eede915fd04f8c6b37. * test(providers/microsoft): move test_get_conn_fallback_to_default_azure_credential into a separate class * test: remove unnecessary marker GitOrigin-RevId: 0fac318a9c9a776dc18f985de494aa253e22e820
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 20, 2025
…ok (#33991) * test(providers/microsoft): add test cases to AzureContainerInstanceHook verify that AzureContainerInstanceHook use DefaultAzureCredential when other credential (i.e., login, password, tenant_id) are not provided apache/airflow#33467 * test(providers/microsoft): improve test_get_conn_fallback_to_default_azure_credential by asserting return conn and called args * test: move marker disable_autouse to conftest * Revert "test: move marker disable_autouse to conftest" This reverts commit ad6c0f2aaf700c6fc58852eede915fd04f8c6b37. * test(providers/microsoft): move test_get_conn_fallback_to_default_azure_credential into a separate class * test: remove unnecessary marker GitOrigin-RevId: 0fac318a9c9a776dc18f985de494aa253e22e820
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 18, 2025
…ok (#33991) * test(providers/microsoft): add test cases to AzureContainerInstanceHook verify that AzureContainerInstanceHook use DefaultAzureCredential when other credential (i.e., login, password, tenant_id) are not provided apache/airflow#33467 * test(providers/microsoft): improve test_get_conn_fallback_to_default_azure_credential by asserting return conn and called args * test: move marker disable_autouse to conftest * Revert "test: move marker disable_autouse to conftest" This reverts commit ad6c0f2aaf700c6fc58852eede915fd04f8c6b37. * test(providers/microsoft): move test_get_conn_fallback_to_default_azure_credential into a separate class * test: remove unnecessary marker GitOrigin-RevId: 0fac318a9c9a776dc18f985de494aa253e22e820
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

This PR depends on #33687
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.