Skip to content

Conversation

@Lee-W
Copy link
Member

@Lee-W Lee-W commented Aug 17, 2023

This PR depends on #33687


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@Lee-W
Copy link
Member Author

Lee-W commented Aug 24, 2023

圖片

@Lee-W Lee-W force-pushed the add-DefaultAzureCredential-support-to-AzureContainerInstanceHook branch from e267423 to aa37281 Compare August 24, 2023 08:51
@Lee-W Lee-W marked this pull request as ready for review August 24, 2023 08:52
Copy link
Member

@pankajastro pankajastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pankajastro pankajastro merged commit faa50cb into apache:main Aug 24, 2023
@pankajastro pankajastro deleted the add-DefaultAzureCredential-support-to-AzureContainerInstanceHook branch August 24, 2023 12:26
Lee-W added a commit to astronomer/airflow that referenced this pull request Sep 1, 2023
verify that AzureContainerInstanceHook use DefaultAzureCredential
when other credential (i.e., login, password, tenant_id) are not provided

apache#33467
eladkal pushed a commit that referenced this pull request Sep 1, 2023
…ok (#33991)

* test(providers/microsoft): add test cases to AzureContainerInstanceHook

verify that AzureContainerInstanceHook use DefaultAzureCredential
when other credential (i.e., login, password, tenant_id) are not provided

#33467

* test(providers/microsoft): improve test_get_conn_fallback_to_default_azure_credential by asserting return conn and called args

* test: move marker disable_autouse to conftest

* Revert "test: move marker disable_autouse to conftest"

This reverts commit ad6c0f2.

* test(providers/microsoft): move test_get_conn_fallback_to_default_azure_credential into a separate class

* test: remove unnecessary marker
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jul 18, 2024
…ok (#33991)

* test(providers/microsoft): add test cases to AzureContainerInstanceHook

verify that AzureContainerInstanceHook use DefaultAzureCredential
when other credential (i.e., login, password, tenant_id) are not provided

apache/airflow#33467

* test(providers/microsoft): improve test_get_conn_fallback_to_default_azure_credential by asserting return conn and called args

* test: move marker disable_autouse to conftest

* Revert "test: move marker disable_autouse to conftest"

This reverts commit ad6c0f2aaf700c6fc58852eede915fd04f8c6b37.

* test(providers/microsoft): move test_get_conn_fallback_to_default_azure_credential into a separate class

* test: remove unnecessary marker

GitOrigin-RevId: 0fac318a9c9a776dc18f985de494aa253e22e820
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 20, 2024
…ok (#33991)

* test(providers/microsoft): add test cases to AzureContainerInstanceHook

verify that AzureContainerInstanceHook use DefaultAzureCredential
when other credential (i.e., login, password, tenant_id) are not provided

apache/airflow#33467

* test(providers/microsoft): improve test_get_conn_fallback_to_default_azure_credential by asserting return conn and called args

* test: move marker disable_autouse to conftest

* Revert "test: move marker disable_autouse to conftest"

This reverts commit ad6c0f2aaf700c6fc58852eede915fd04f8c6b37.

* test(providers/microsoft): move test_get_conn_fallback_to_default_azure_credential into a separate class

* test: remove unnecessary marker

GitOrigin-RevId: 0fac318a9c9a776dc18f985de494aa253e22e820
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Nov 8, 2024
…ok (#33991)

* test(providers/microsoft): add test cases to AzureContainerInstanceHook

verify that AzureContainerInstanceHook use DefaultAzureCredential
when other credential (i.e., login, password, tenant_id) are not provided

apache/airflow#33467

* test(providers/microsoft): improve test_get_conn_fallback_to_default_azure_credential by asserting return conn and called args

* test: move marker disable_autouse to conftest

* Revert "test: move marker disable_autouse to conftest"

This reverts commit ad6c0f2aaf700c6fc58852eede915fd04f8c6b37.

* test(providers/microsoft): move test_get_conn_fallback_to_default_azure_credential into a separate class

* test: remove unnecessary marker

GitOrigin-RevId: 0fac318a9c9a776dc18f985de494aa253e22e820
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request May 4, 2025
…ok (#33991)

* test(providers/microsoft): add test cases to AzureContainerInstanceHook

verify that AzureContainerInstanceHook use DefaultAzureCredential
when other credential (i.e., login, password, tenant_id) are not provided

apache/airflow#33467

* test(providers/microsoft): improve test_get_conn_fallback_to_default_azure_credential by asserting return conn and called args

* test: move marker disable_autouse to conftest

* Revert "test: move marker disable_autouse to conftest"

This reverts commit ad6c0f2aaf700c6fc58852eede915fd04f8c6b37.

* test(providers/microsoft): move test_get_conn_fallback_to_default_azure_credential into a separate class

* test: remove unnecessary marker

GitOrigin-RevId: 0fac318a9c9a776dc18f985de494aa253e22e820
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request May 25, 2025
…ok (#33991)

* test(providers/microsoft): add test cases to AzureContainerInstanceHook

verify that AzureContainerInstanceHook use DefaultAzureCredential
when other credential (i.e., login, password, tenant_id) are not provided

apache/airflow#33467

* test(providers/microsoft): improve test_get_conn_fallback_to_default_azure_credential by asserting return conn and called args

* test: move marker disable_autouse to conftest

* Revert "test: move marker disable_autouse to conftest"

This reverts commit ad6c0f2aaf700c6fc58852eede915fd04f8c6b37.

* test(providers/microsoft): move test_get_conn_fallback_to_default_azure_credential into a separate class

* test: remove unnecessary marker

GitOrigin-RevId: 0fac318a9c9a776dc18f985de494aa253e22e820
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 20, 2025
…ok (#33991)

* test(providers/microsoft): add test cases to AzureContainerInstanceHook

verify that AzureContainerInstanceHook use DefaultAzureCredential
when other credential (i.e., login, password, tenant_id) are not provided

apache/airflow#33467

* test(providers/microsoft): improve test_get_conn_fallback_to_default_azure_credential by asserting return conn and called args

* test: move marker disable_autouse to conftest

* Revert "test: move marker disable_autouse to conftest"

This reverts commit ad6c0f2aaf700c6fc58852eede915fd04f8c6b37.

* test(providers/microsoft): move test_get_conn_fallback_to_default_azure_credential into a separate class

* test: remove unnecessary marker

GitOrigin-RevId: 0fac318a9c9a776dc18f985de494aa253e22e820
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 18, 2025
…ok (#33991)

* test(providers/microsoft): add test cases to AzureContainerInstanceHook

verify that AzureContainerInstanceHook use DefaultAzureCredential
when other credential (i.e., login, password, tenant_id) are not provided

apache/airflow#33467

* test(providers/microsoft): improve test_get_conn_fallback_to_default_azure_credential by asserting return conn and called args

* test: move marker disable_autouse to conftest

* Revert "test: move marker disable_autouse to conftest"

This reverts commit ad6c0f2aaf700c6fc58852eede915fd04f8c6b37.

* test(providers/microsoft): move test_get_conn_fallback_to_default_azure_credential into a separate class

* test: remove unnecessary marker

GitOrigin-RevId: 0fac318a9c9a776dc18f985de494aa253e22e820
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants