test(providers/microsoft): add test cases to AzureContainerInstanceHook #33991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:microsoft-azure
uranusjr
reviewed
Sep 1, 2023
tests/providers/microsoft/azure/hooks/test_azure_container_instance.py
Outdated
Show resolved
Hide resolved
uranusjr
reviewed
Sep 1, 2023
verify that AzureContainerInstanceHook use DefaultAzureCredential when other credential (i.e., login, password, tenant_id) are not provided apache#33467
…azure_credential by asserting return conn and called args
Lee-W
force-pushed
the
add-test-case-to-AzureContainerInstanceHook-when-credential-is-not-provided-from-conn
branch
from
7ed28c8 to
ad6c0f2
Compare
This reverts commit ad6c0f2.
…re_credential into a separate class
uranusjr
reviewed
Sep 1, 2023
uranusjr
approved these changes
Sep 1, 2023
Member
Author
|
It seems the CI failure has been fixed in #34001. I'll wait for the PR to be merged and rebase that back to this one. |
pankajastro
approved these changes
Sep 1, 2023
…when-credential-is-not-provided-from-conn
phanikumv
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verify that AzureContainerInstanceHook use DefaultAzureCredential
when other credentials (i.e., login, password, tenant_id) are not provided
Add missing test cases to #33467
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.