Fix Literal redefinition in providers_manager.py
#34001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taragolis
added
the
type:misc/internal
|
|
||
| from airflow.decorators.base import TaskDecorator | ||
| from airflow.hooks.base import BaseHook | ||
| from airflow.typing_compat import Literal |
Member
There was a problem hiding this comment.
Why do you import it from airflow.typing_compact and not from typing_extension?
Contributor
Author
There was a problem hiding this comment.
Short version: We decided to use airflow.typing_compat into the core. Providers still directly use typing_extension
hussein-awala
approved these changes
Sep 1, 2023
ephraimbuddy
added
changelog:skip
ephraimbuddy
pushed a commit
that referenced
this pull request
Oct 31, 2023
(cherry picked from commit 3747483)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.