Add Celery extra in Breeze when using CeleryExecutor and --use-airflow#34089
Merged
potiuk merged 1 commit intoapache:mainfrom Sep 5, 2023
Merged
Add Celery extra in Breeze when using CeleryExecutor and --use-airflow#34089potiuk merged 1 commit intoapache:mainfrom
potiuk merged 1 commit intoapache:mainfrom
Conversation
potiuk
requested review from
Taragolis,
eladkal,
ephraimbuddy,
pankajkoti,
uranusjr and
utkarsharma2
and removed request for
ashb and
jedcunningham
pankajkoti
reviewed
Sep 5, 2023
When using `--executor CeleryExecutor` and `--use-airflow` in Airflow 2.7+ you need to also specify `--airflow-extras celery` to make it works. With this change `--airflow-extras celery` is added automatically when CeleryExecutor is used and when `--use-airflow` is specified (unless you manually specify your own extras. This makes it easier to test RC releases with CeleryExecutor.
potiuk
force-pushed
the
add-celery-extra-for-use-airflow
branch
from
328b7c2 to
cbb9bd0
Compare
uranusjr
approved these changes
Sep 5, 2023
utkarsharma2
approved these changes
Sep 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
--executor CeleryExecutorand--use-airflowin Airflow 2.7+ you need to also specify--airflow-extras celeryto make it works. With this change--airflow-extras celeryis added automatically when CeleryExecutor is used and when--use-airflowis specified (unless you manually specify your own extras.This makes it easier to test RC releases with CeleryExecutor.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.