Skip to content

Fallback to bash if SHELL variable is not set for k8s shell#36985

Merged
hussein-awala merged 1 commit intoapache:mainfrom
potiuk:add-fallback-to-shell-retrieval-on-k8s-shell
Jan 23, 2024
Merged

Fallback to bash if SHELL variable is not set for k8s shell#36985
hussein-awala merged 1 commit intoapache:mainfrom
potiuk:add-fallback-to-shell-retrieval-on-k8s-shell

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Jan 23, 2024

When SHELL variable is not set, k8s shell command falls back to bash rather than failing with key error.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

When SHELL variable is not set, k8s shell command falls back to bash
rather than failing with key error.
@potiuk
Copy link
Member Author

potiuk commented Jan 23, 2024

Looks like in some cicumstances (public runners) SHELL variable might not be set up - this failed in #34089 for @RNHTTR

@hussein-awala hussein-awala merged commit 1a99487 into apache:main Jan 23, 2024
potiuk added a commit that referenced this pull request Feb 7, 2024
When SHELL variable is not set, k8s shell command falls back to bash
rather than failing with key error.

(cherry picked from commit 1a99487)
@potiuk potiuk added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Feb 8, 2024
@potiuk potiuk added this to the Airflow 2.8.2 milestone Feb 8, 2024
ephraimbuddy pushed a commit that referenced this pull request Feb 22, 2024
When SHELL variable is not set, k8s shell command falls back to bash
rather than failing with key error.

(cherry picked from commit 1a99487)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants