Fix is_parent_mapped value by checking if any of the parent tg is mapped #34587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hussein-awala
added
area:webserver
hussein-awala
requested review from
ashb,
bbovenzi,
pierrejeambrun and
ryanahamilton
as code owners
2 tasks
pierrejeambrun
approved these changes
Sep 24, 2023
bbovenzi
approved these changes
Sep 25, 2023
fritz-astronomer
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #34535
Currently we check only if the direct task group parent is mapped to consider that the task instance is mapped on the UI, however, when any of the parents of the task group is mapped (for example a nested tg in a mapped tg), the task will be mapped.
This PR fixes the issue by check if any of the parents is mapped task group.