Use iterative loop to look for mapped parent #34622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the logic in views to look for a parent mapped task group (so to decide whether a task group is mapped) from using a recursive function to an iterative loop. This should help prevent RecursionError when a DAG has deeply-nested task groups. I hope no-one really writes such a DAG in practice, but you never know. Also in cases both solutions work, the loop should generally be faster anyway due to how CPython is implemented.
uranusjr
requested review from
ashb,
bbovenzi,
pierrejeambrun and
ryanahamilton
as code owners
hussein-awala
approved these changes
Sep 26, 2023
Member
hussein-awala
left a comment
hussein-awala
left a comment
There was a problem hiding this comment.
I didn't pay attention that we already have a method to get the mapped task groups (parent tg), LGTM
ephraimbuddy
pushed a commit
that referenced
this pull request
Oct 5, 2023
(cherry picked from commit d9ba152)
99 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative fix to #34587.
This changes the logic in views to look for a parent mapped task group (so to decide whether a task group is mapped) from using a recursive function to an iterative loop. This should help prevent RecursionError when a DAG has deeply-nested task groups. I hope no-one really writes such a DAG in practice, but you never know. Also in cases both solutions work, the loop should generally be faster anyway due to how CPython is implemented.