Skip to content

Conversation

@sekikn
Copy link
Contributor

@sekikn sekikn commented Jun 28, 2018

Make sure you have checked all steps below.

JIRA

  • My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

Description

  • Here are some details about my PR, including screenshots of any UI changes:

This PR moves the package unittest2 from
devel_ci to devel in setup.py, since
the latter is the minimal required packages
for development and unittest2 is considered
as one of them.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

No additional test, since it's a fix for library dependency, not for feature.
I ran pip install -U -e "[.devel]" locally, and confirmed that unittest2 is installed on Python2 and not on Python3.

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

  • Passes git diff upstream/master -u -- "*.py" | flake8 --diff

This PR moves the package unittest2 from
devel_ci to devel in setup.py, since
the latter is the minimal required packages
for development and unittest2 is considered
as one of them.
@codecov-io
Copy link

Codecov Report

Merging #3555 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3555   +/-   ##
=======================================
  Coverage   77.45%   77.45%           
=======================================
  Files         204      204           
  Lines       15299    15299           
=======================================
  Hits        11850    11850           
  Misses       3449     3449

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0061f1...f42bfec. Read the comment docs.

@Fokko
Copy link
Contributor

Fokko commented Jun 29, 2018

Can't we change this to something that is both Python 2 and 3 compatible? Also not PY3 is less readable than PY2.

@sekikn
Copy link
Contributor Author

sekikn commented Jul 18, 2018

Closing this since the same fix has already been merged as #3581.

@sekikn sekikn closed this Jul 18, 2018
@ron819
Copy link
Contributor

ron819 commented Aug 9, 2018

@sekikn The jira ticket is still open

@sekikn
Copy link
Contributor Author

sekikn commented Aug 9, 2018

@ron819 @ashb Thanks for notifying and closing ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants